To close this up.
My pump was knocking because of a vacuum leak at the fittings coming off my gas tank. Somone sealed the fittings with plumbers tape and over time they started to leak. I used PERMATEX Aviation Form-A-Gasket No. 3 sealant to reseal everything. = no more knocking.
Problem solved
Thanks for the help!